Re: [PATCH v3 5/7] backlight: gpio: remove dev from struct gpio_backlight

From: Daniel Thompson
Date: Wed Jul 24 2019 - 07:13:18 EST


On Wed, Jul 24, 2019 at 10:25:06AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> This field is unused. Remove it.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>

> ---
> drivers/video/backlight/gpio_backlight.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index 01262186fa1e..70882556f047 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -19,9 +19,7 @@
> #include <linux/slab.h>
>
> struct gpio_backlight {
> - struct device *dev;
> struct device *fbdev;
> -
> struct gpio_desc *gpiod;
> int def_value;
> };
> @@ -69,8 +67,6 @@ static int gpio_backlight_probe(struct platform_device *pdev)
> if (gbl == NULL)
> return -ENOMEM;
>
> - gbl->dev = &pdev->dev;
> -
> if (pdata)
> gbl->fbdev = pdata->fbdev;
>
> --
> 2.21.0
>