Re: [PATCH v4 2/3] treewide: Remove dev_err() usage after platform_get_irq()

From: Greg Kroah-Hartman
Date: Wed Jul 24 2019 - 02:35:25 EST


On Tue, Jul 23, 2019 at 11:16:23AM -0700, Stephen Boyd wrote:
> diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
> index 9b2232908b65..40e4e8e03428 100644
> --- a/sound/soc/sunxi/sun4i-i2s.c
> +++ b/sound/soc/sunxi/sun4i-i2s.c
> @@ -1088,7 +1088,6 @@ static int sun4i_i2s_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "Can't retrieve our interrupt\n");
> return irq;
> }
>

Just one example here, but you really want to remove those { } now as
well.

That's in this patch a lot, so as-is, I don't think this is ok, sorry.

greg k-h