Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n

From: Christoph Hellwig
Date: Thu Jul 18 2019 - 08:57:08 EST


On Thu, Jul 18, 2019 at 02:55:01PM +0200, Arnd Bergmann wrote:
> When CONFIG_BLOCK is disabled, SECTOR_SHIFT is unknown:
>
> In file included from <built-in>:3:
> include/linux/iomap.h:76:48: error: use of undeclared identifier 'SECTOR_SHIFT'
> return (iomap->addr + pos - iomap->offset) >> SECTOR_SHIFT;
>
> Since there are no callers in this case, just hide the function in
> the same ifdef.
>
> Fixes: db074436f421 ("iomap: move the direct IO code into a separate file")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Can we just not include iomap.c when CONFIG_BLOCK is not set?
Which file do you see this with?