Re: [2/2] ASoC: samsung: odroid: fix a double-free issue for cpu_dai

From: Markus Elfring
Date: Mon Jul 15 2019 - 02:41:48 EST


> These two updates fix two different bugs.

I can follow this view to some degree.


> and the other is the double-free issue

This programming error affects also the use of data structures which became invalid.
https://cwe.mitre.org/data/definitions/415.html#oc_415_Notes


> So we sent two patches to fix them separately.

You would like to fix something according to two variables (of the data type âdevice_node *â)
in the same function implementation.
Please combine these corrections in an update step under a topic like
âASoC: samsung: odroid: Fix handling of device node references in odroid_audio_probe()â.
(The previous update step would contain still a known programming mistake otherwise,
wouldn't it?)

Regards,
Markus