Re: [PATCH 2/5] KVM: cpuid: extract do_cpuid_7_mask and support multiple subleafs

From: Paolo Bonzini
Date: Wed Jul 10 2019 - 03:48:26 EST


On 10/07/19 09:32, Jing Liu wrote:
>
>
> On 7/10/2019 2:30 PM, Paolo Bonzini wrote:
>> On 08/07/19 09:07, Jing Liu wrote:
>>>>
>>> And when adding subleaf 1, plan to add codes,
>>>
>>> case 1:
>>> ÂÂÂÂÂentry->eax |= kvm_cpuid_7_1_eax_x86_features;
>>> ÂÂÂÂÂentry->ebx = entry->ecx = entry->edx =0;
>>> ÂÂÂÂÂbreak;
>>>
>>> What do you think?
>>
>> This should be "&=", not "|=". Otherwise yes, that's the idea.
>>
>
> Yes! So let me send out the BFloat16 patch based on your patch set now
> or you have merge plan soon?

Just send it . :)

Paolo