RE: [PATCH 1/3] opp: of: Support multiple suspend OPPs defined in DT

From: Anson Huang
Date: Tue Jul 09 2019 - 03:54:20 EST


Hi, Viresh

> On 09-07-19, 15:10, Anson.Huang@xxxxxxx wrote:
> > From: Anson Huang <Anson.Huang@xxxxxxx>
> >
> > With property "opp-supported-hw" introduced, the OPP table in DT could
> > be a large OPP table and ONLY a subset of OPPs are available, based on
> > the version of the hardware running on. That introduces restriction of
> > using "opp-suspend"
> > property to define the suspend OPP, as we are NOT sure if the OPP
> > containing "opp-suspend" property is available for the hardware
> > running on, and the of opp core does NOT allow multiple suspend OPPs
> > defined in DT OPP table.
> >
> > To eliminate this restrition, make of opp core allow multiple suspend
> > OPPs defined in DT, and pick the OPP with highest rate and with
> > "opp-suspend" property present to be suspend OPP, it can speed up the
> > suspend/resume process.
> >
> > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> > ---
> > drivers/opp/of.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
>
> Please update the DT bindings first.

OK, will send a V2 containing DT binding changes.

>
> FWIW, all three patches look fine otherwise.

Thank you!

Anson.