Re: [PATCH] drm/amd/display: dcn20: include linux/delay.h

From: Alex Deucher
Date: Mon Jul 08 2019 - 12:01:31 EST


On Mon, Jul 8, 2019 at 9:53 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> Without this header, we get a compiler error in some configurations:
>
> .../dc/dcn20/dcn20_hwseq.c: In function 'dcn20_hwss_wait_for_blank_complete':
> .../dc/dcn20/dcn20_hwseq.c:1493:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
>
> Note: the use of udelay itself may be problematic, as can occupy
> the CPU for 200ms in a busy-loop here.
>
> Fixes: 7ed4e6352c16 ("drm/amd/display: Add DCN2 HW Sequencer and Resource")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied. thanks!

Alex

> ---
> drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c
> index 4b0d8b9f61da..6925d25d2457 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hwseq.c
> @@ -22,6 +22,7 @@
> * Authors: AMD
> *
> */
> +#include <linux/delay.h>
>
> #include "dm_services.h"
> #include "dm_helpers.h"
> --
> 2.20.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel