Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default

From: Douglas Gilbert
Date: Mon Jul 08 2019 - 09:02:42 EST


On 2019-07-08 2:01 a.m., Hannes Reinecke wrote:
On 7/5/19 7:53 PM, Douglas Gilbert wrote:
On 2019-07-05 3:22 a.m., Hannes Reinecke wrote:
[ .. ]
As mentioned, rescan-scsi-bus.sh is keeping references to /proc/scsi as
a fall back only, as it's meant to work kernel independent. Per default
it'll be using /sys, and will happily work without /proc/scsi.

So it's really only /proc/scsi/sg which carries some meaningful
information; maybe we should move/copy it to somewhere else.

I personally like getting rid of /proc/scsi.

/proc/scsi/device_info doesn't seem to be in sysfs.

Could the contents of /proc/scsi/sg/* be placed in
/sys/class/scsi_generic/* ? Currently that directory only has symlinks
to the sg devices.

The sg parameters are already available in /sys/module/sg/parameters;
so from that perspective I feel we're good.

# ls /sys/module/sg/parameters/
allow_dio def_reserved_size scatter_elem_sz

# ls /proc/scsi/sg/
allow_dio debug def_reserved_size device_hdr devices device_strs
red_debug version

So that doesn't work, what are in 'parameters' are passed in at
module/driver initialization. Back to my original question: Could the
contents of /proc/scsi/sg/* be placed in /sys/class/scsi_generic/* ?

Problem is /proc/scsi/device_info, for which we currently don't have any
other location to store it at.
Hmm.

Doug Gilbert