Re: [PATCH V7 7/7] cpufreq: Add QoS requests for userspace constraints

From: Rafael J. Wysocki
Date: Fri Jul 05 2019 - 07:17:53 EST


On Fri, Jul 5, 2019 at 12:52 PM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> This implements QoS requests to manage userspace configuration of min
> and max frequency.
>
> Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
> V6->V7:
> - We can't call dev_pm_qos_remove_request() for a request which was
> never added. This happened in one of the error paths. Fixed that by
> allocating the requests only right before we try to add them and also
> take care of things properly during errors.
>
> @Rafael: Please apply this version instead of the diff I supplied on the
> WARN email earlier. This has proper protection in place at many places.

Applied, thanks!