Re: [PATCH 2/4] gpio: stp-xway: improve module clock error handling

From: Linus Walleij
Date: Thu Jul 04 2019 - 03:40:39 EST


On Wed, Jul 3, 2019 at 12:33 AM Martin Blumenstingl
<martin.blumenstingl@xxxxxxxxxxxxxx> wrote:

> Three module clock error handling improvements:
> - use devm_clk_get() so the clock instance can be freed if
> devm_gpiochip_add_data() fails later on
> - switch to clk_prepare_enable() so the driver is ready whenever the
> lantiq target switches to the common clock framework
> - disable the clock again (using clk_disable_unprepare()) if
> devm_gpiochip_add_data()
>
> All of these are virtually no-ops with the current lantiq target.
> However, these will be relevant if we switch to the common clock
> framework.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

Patch applied.

Yours,
Linus Walleij