Re: [GIT PULL 1/9] intel_th: msu: Fix unused variable warning on arm64 platform

From: Alexander Shishkin
Date: Wed Jul 03 2019 - 11:54:11 EST


Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes:

> On Thu, Jun 27, 2019 at 03:51:44PM +0300, Alexander Shishkin wrote:
>> From: Shaokun Zhang <zhangshaokun@xxxxxxxxxxxxx>
>>
>> Commit ba39bd8306057 ("intel_th: msu: Switch over to scatterlist")
>> introduced the following warnings on non-x86 architectures, as a result
>> of reordering the multi mode buffer allocation sequence:
>>
>> > drivers/hwtracing/intel_th/msu.c: In function âmsc_buffer_win_allocâ:
>> > drivers/hwtracing/intel_th/msu.c:783:21: warning: unused variable âiâ
>> > [-Wunused-variable]
>> > int ret = -ENOMEM, i;
>> > ^
>> > drivers/hwtracing/intel_th/msu.c: In function âmsc_buffer_win_freeâ:
>> > drivers/hwtracing/intel_th/msu.c:863:6: warning: unused variable âiâ
>> > [-Wunused-variable]
>> > int i;
>> > ^
>>
>> Fix this compiler warning by factoring out set_memory sequences and making
>> them x86-only.
>>
>> Suggested-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@xxxxxxxxxxxxx>
>> Fixes: ba39bd8306057 ("intel_th: msu: Switch over to scatterlist")
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> Signed-off-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
>> ---
>> drivers/hwtracing/intel_th/msu.c | 40 +++++++++++++++++++++-----------
>> 1 file changed, 27 insertions(+), 13 deletions(-)
>
> Does not apply to my tree :(

It's the same one as the one in the fixes series. I just put it here for
completeness.

Regards,
--
Alex