Re: [PATCH 00/12] ARM: davinci: da850-evm: remove more legacy GPIO calls

From: Daniel Thompson
Date: Tue Jul 02 2019 - 06:06:52 EST


On Tue, Jul 02, 2019 at 07:36:53AM +0100, Lee Jones wrote:
> On Mon, 01 Jul 2019, Sekhar Nori wrote:
>
> > Hi Lee, Daniel, Jingoo,
> >
> > On 25/06/19 10:04 PM, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > >
> > > This is another small step on the path to liberating davinci from legacy
> > > GPIO API calls and shrinking the davinci GPIO driver by not having to
> > > support the base GPIO number anymore.
> > >
> > > This time we're removing the legacy calls used indirectly by the LCDC
> > > fbdev driver.
> > >
> > > The first three patches modify the GPIO backlight driver. The first
> > > of them adds the necessary functionality, the other two are just
> > > tweaks and cleanups.
> >
> > Can you take the first three patches for v5.3 - if its not too late? I
> > think that will make it easy for rest of patches to make into subsequent
> > kernel releases.
>
> It's already too late in the cycle (-rc7) for that. I require patches
> of this nature to have a good soak in -next before being merged. There
> shouldn't be an issue with getting them into v5.4 though.

On the other hand I think we did take a patch that did much the same
thing as patch 1/12 in this series:
https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git/commit/?h=for-backlight-next&id=98b7404eb7d64e55f8fdd419cb3965a8abf0e217

I'm not 100% sure but I think that might allow the patchset to be split
into two that are independent (one for Davinci and one for gpio
backlight improvements).


Daniel.

>
> > > Next two patches enable the GPIO backlight driver in
> > > davinci_all_defconfig.
> > >
> > > Patch 6/12 models the backlight GPIO as an actual GPIO backlight device.
> > >
> > > Patches 7-9 extend the fbdev driver with regulator support and convert
> > > the da850-evm board file to using it.
> > >
> > > Last three patches are improvements to the da8xx fbdev driver since
> > > we're already touching it in this series.
> >
> > Thanks,
> > Sekhar
> >
>
> --
> Lee Jones [æçæ]
> Linaro Services Technical Lead
> Linaro.org â Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog