Re: [PATCH] cpufreq: pcc-cpufreq: Fail initialization if driver cannot be registered

[Viresh Kumar]

On 06-06-19, 14:50, David Arcari wrote:
> Make pcc_cpufreq_init() return error codes when the driver cannot be
> registered.  Otherwise the driver can shows up loaded via lsmod even
> though it failed initialization.  This is confusing to the user.
> 
> Signed-off-by: David Arcari <darcari@xxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
>  drivers/cpufreq/pcc-cpufreq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
> index 1e5e64643c3a..fdc767fdbe6a 100644
> --- a/drivers/cpufreq/pcc-cpufreq.c
> +++ b/drivers/cpufreq/pcc-cpufreq.c
> @@ -582,10 +582,10 @@ static int __init pcc_cpufreq_init(void)
>  
>  	/* Skip initialization if another cpufreq driver is there. */
>  	if (cpufreq_get_current_driver())
> -		return 0;
> +		return -EEXIST;
>  
>  	if (acpi_disabled)
> -		return 0;
> +		return -ENODEV;
>  
>  	ret = pcc_cpufreq_probe();
>  	if (ret) {

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

-- 
viresh