Re: [PATCH] staging: kpc2000: Fix build failure caused by wrong include file

From: Greg Kroah-Hartman
Date: Thu May 30 2019 - 18:01:02 EST


On Thu, May 30, 2019 at 04:33:42AM -0700, Guenter Roeck wrote:
> xtensa:allmodconfig fails to build.
>
> arch/xtensa/include/asm/uaccess.h: In function 'clear_user':
> arch/xtensa/include/asm/uaccess.h:40:22: error:
> implicit declaration of function 'uaccess_kernel'
>
> uaccess_kernel() is declared in linux/uaccess.h, not asm/uaccess.h.
>
> Fixes: 7df95299b94a ("staging: kpc2000: Add DMA driver")
> Cc: Matt Sickler <Matt.Sickler@xxxxxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/staging/kpc2000/kpc_dma/fileops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/kpc2000/kpc_dma/fileops.c b/drivers/staging/kpc2000/kpc_dma/fileops.c
> index 5741d2b49a7d..e741fa753ca1 100644
> --- a/drivers/staging/kpc2000/kpc_dma/fileops.c
> +++ b/drivers/staging/kpc2000/kpc_dma/fileops.c
> @@ -8,7 +8,7 @@
> #include <linux/errno.h> /* error codes */
> #include <linux/types.h> /* size_t */
> #include <linux/cdev.h>
> -#include <asm/uaccess.h> /* copy_*_user */
> +#include <linux/uaccess.h> /* copy_*_user */
> #include <linux/aio.h> /* aio stuff */
> #include <linux/highmem.h>
> #include <linux/pagemap.h>

Already fixed by e00839f38823 ("staging: kpc2000: fix build error on
xtensa") in my staging-linus branch.

thanks,

greg k-h