Re: [PATCH bpf-next 5/5] bpf: move memory size checks to bpf_map_charge_init()

From: Roman Gushchin
Date: Thu May 30 2019 - 15:14:09 EST


On Thu, May 30, 2019 at 11:56:55AM -0700, Song Liu wrote:
> On Wed, May 29, 2019 at 6:05 PM Roman Gushchin <guro@xxxxxx> wrote:
> >
> > Most bpf map types doing similar checks and bytes to pages
> > conversion during memory allocation and charging.
> >
> > Let's unify these checks by moving them into bpf_map_charge_init().
> >
> > Signed-off-by: Roman Gushchin <guro@xxxxxx>
>
> Nice, I was thinking about similar issues while reading patches
> 3/5 and 4/5. I really like this simplification.
>
> Acked-by: Song Liu <songliubraving@xxxxxx>

Thank you for the review, Song!