Re: [PATCH v2] x86/power: Fix 'nosmt' vs. hibernation triple fault during resume

From: Jiri Kosina
Date: Wed May 29 2019 - 13:33:24 EST


On Wed, 29 May 2019, Josh Poimboeuf wrote:

> I still have the question about whether we could make mwait_play_dead()
> monitor a fixed address. If we could get that to work, that seems more
> robust to me.

Hmm, does it really?

That'd mean the resumer and resumee must have the same fixmap. How are you
going to guarantee that? Currently the resuming kernel doesn't really have
to be the same as the one that is being resumed.

> Another question. With your patch, if booted with nosmt, is SMT still
> disabled after you resume from hibernation?

Yup, it is.

> I don't see how SMT would get disabled again.

The target kernel only onlines the CPUs which were online at the time of
hibernation (and are therefore in frozen_cpus mask).

--
Jiri Kosina
SUSE Labs