Re: [PATCH net-next] net: dsa: sja1105: Make static_config_check_memory_size static

From: Vladimir Oltean
Date: Wed May 29 2019 - 11:28:21 EST


On Wed, 29 May 2019 at 17:35, YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>
> Fix sparse warning:
>
> drivers/net/dsa/sja1105/sja1105_static_config.c:446:1: warning:
> symbol 'static_config_check_memory_size' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
> drivers/net/dsa/sja1105/sja1105_static_config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105_static_config.c b/drivers/net/dsa/sja1105/sja1105_static_config.c
> index b3c992b0abb0..7e90e62da389 100644
> --- a/drivers/net/dsa/sja1105/sja1105_static_config.c
> +++ b/drivers/net/dsa/sja1105/sja1105_static_config.c
> @@ -442,7 +442,7 @@ const char *sja1105_static_config_error_msg[] = {
> "vl-forwarding-parameters-table.partspc.",
> };
>
> -sja1105_config_valid_t
> +static sja1105_config_valid_t
> static_config_check_memory_size(const struct sja1105_table *tables)
> {
> const struct sja1105_l2_forwarding_params_entry *l2_fwd_params;
> --
> 2.17.1
>
>

Acked-by: Vladimir Oltean <olteanv@xxxxxxxxx>