Re: [PATCH] wd719x: pass GFP_ATOMIC instead of GFP_KERNEL

From: Christoph Hellwig
Date: Wed May 29 2019 - 02:26:43 EST


On Wed, May 29, 2019 at 07:05:40AM +0530, Hariprasad Kelam wrote:
> wd719x_chip_init is getting called in interrupt disabled
> mode(spin_lock_irqsave) , so we need to GFP_ATOMIC instead
> of GFP_KERNEL.
>
> Issue identified by coccicheck

I don't think request_firmware is any more happy being called under
a spinlock. The right fix is to not hold a spinlock over the board
initialization.