Re: [PATCH 1/7] keys: sparse: Fix key_fs[ug]id_changed()

From: James Morris
Date: Fri May 24 2019 - 15:41:44 EST


On Wed, 22 May 2019, David Howells wrote:

> Sparse warnings are incurred by key_fs[ug]id_changed() due to unprotected
> accesses of tsk->cred, which is marked __rcu.
>
> Fix this by passing the new cred struct to these functions from
> commit_creds() rather than the task pointer.
>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>


Reviewed-by: James Morris <jamorris@xxxxxxxxxxxxxxxxxxx>


--
James Morris
<jmorris@xxxxxxxxx>