Re: [PATCH v2] consolemap: Fix a memory leaking bug in con_insert_unipair()

From: Greg KH
Date: Fri May 24 2019 - 04:05:02 EST


On Fri, May 24, 2019 at 10:19:32AM +0800, Gen Zhang wrote:
> In function con_insert_unipair(), when allocation for p2 and p1[n]
> fails, ENOMEM is returned, but previously allocated p1 is not freed,
> remains as leaking memory. Thus we should free p1 as well when this
> allocation fails.
>
> Signed-off-by: Gen Zhang <blackgod016574@xxxxxxxxx>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

Any reason you keep dropping me from this thread?

It's as if you don't want me to apply the patch :(

greg k-h