RE: [PATCH v4] clk: qoriq: add support for lx2160a

From: Vabhav Sharma
Date: Thu May 23 2019 - 10:08:18 EST


> -----Original Message-----
> From: Vabhav Sharma
> Sent: Tuesday, May 21, 2019 11:14 AM
> To: linux-kernel@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx;
> sboyd@xxxxxxxxxx
> Cc: mturquette@xxxxxxxxxxxx; Andy Tang <andy.tang@xxxxxxx>; Yogesh
> Narayan Gaur <yogeshnarayan.gaur@xxxxxxx>
> Subject: RE: [PATCH v4] clk: qoriq: add support for lx2160a
>
> Hello Stephen,
> I have incorporated review comments from
> https://patchwork.kernel.org/patch/10917171/
Hello Maintainers,
All the comments are addressed, Can you please take the patch?
Please see this is essential for new hardware support.

Regards,
Vabhav
>
> A gentle reminder to apply the patch
> https://patchwork.kernel.org/patch/10918407/.
>
> Regards,
> Vabhav
>
> > -----Original Message-----
> > From: Vabhav Sharma <vabhav.sharma@xxxxxxx>
> > Sent: Friday, April 26, 2019 12:24 PM
> > To: linux-kernel@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx
> > Cc: sboyd@xxxxxxxxxx; mturquette@xxxxxxxxxxxx; Vabhav Sharma
> > <vabhav.sharma@xxxxxxx>; Andy Tang <andy.tang@xxxxxxx>; Yogesh
> Narayan
> > Gaur <yogeshnarayan.gaur@xxxxxxx>
> > Subject: [PATCH v4] clk: qoriq: add support for lx2160a
> >
> > Add clockgen support and configuration for NXP SoC lx2160a with
> > compatible property as "fsl,lx2160a-clockgen".
> >
> > Signed-off-by: Tang Yuantian <andy.tang@xxxxxxx>
> > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@xxxxxxx>
> > Signed-off-by: Vabhav Sharma <vabhav.sharma@xxxxxxx>
> > Acked-by: Scott Wood <oss@xxxxxxxxxxxx>
> > Acked-by: Stephen Boyd <sboyd@xxxxxxxxxx>
> > Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > ---
> > Changes for v4:
> > - Incorporated review comments from Stephen Boyd
> >
> > Changes for v3:
> > - Incorporated review comments of Rafael J. Wysocki
> > - Updated commit message
> >
> > Changes for v2:
> > - Subject line updated
> >
> > drivers/clk/clk-qoriq.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index
> > 3d51d7c..1a15201 100644
> > --- a/drivers/clk/clk-qoriq.c
> > +++ b/drivers/clk/clk-qoriq.c
> > @@ -570,6 +570,17 @@ static const struct clockgen_chipinfo chipinfo[] = {
> > .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> > },
> > {
> > + .compat = "fsl,lx2160a-clockgen",
> > + .cmux_groups = {
> > + &clockgen2_cmux_cga12, &clockgen2_cmux_cgb
> > + },
> > + .cmux_to_group = {
> > + 0, 0, 0, 0, 1, 1, 1, 1, -1
> > + },
> > + .pll_mask = 0x37,
> > + .flags = CG_VER3 | CG_LITTLE_ENDIAN,
> > + },
> > + {
> > .compat = "fsl,p2041-clockgen",
> > .guts_compat = "fsl,qoriq-device-config-1.0",
> > .init_periph = p2041_init_periph,
> > @@ -1427,6 +1438,7 @@ CLK_OF_DECLARE(qoriq_clockgen_ls1043a,
> > "fsl,ls1043a-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1088a, "fsl,ls1088a-
> > clockgen", clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls2080a,
> > "fsl,ls2080a-clockgen", clockgen_init);
> > +CLK_OF_DECLARE(qoriq_clockgen_lx2160a, "fsl,lx2160a-clockgen",
> > +clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_p2041, "fsl,p2041-clockgen",
> > clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_p3041,
> > "fsl,p3041-clockgen", clockgen_init);
> > CLK_OF_DECLARE(qoriq_clockgen_p4080, "fsl,p4080-clockgen",
> > clockgen_init);
> > --
> > 2.7.4