Re: [GIT PULL] SPDX update for 5.2-rc1 - round 1

From: Thomas Gleixner
Date: Thu May 23 2019 - 01:37:08 EST


On Wed, 22 May 2019, Joe Perches wrote:

> On Thu, 2019-05-23 at 11:49 +0900, Masahiro Yamada wrote:
> > On Wed, May 22, 2019 at 3:37 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
> []
> > > I could also wire up a patch to checkpatch and docs to
> > > remove the /* */ requirement for .h files and prefer
> > > the generic // form for both .c and .h files as the
> > > current minimum tooling versions now all allow //
> > > comments
> > > .
> >
> > We have control for minimal tool versions for building the kernel,
> > so I think // will be OK for in-kernel headers.
> >
> >
> > On the other hand, I am not quite sure about UAPI headers.
> > We cannot define minimum tool versions
> > for building user-space.
> > Perhaps, using // in UAPI headers causes a problem
> > if an ancient compiler is used?
>
> Good point. Thanks.

Indeed. Did not think about the UAPI part at all.

Thanks,

tglx