Re: [PATCH v2] configfs: Fix use-after-free when accessing sd->s_dentry

From: Sahitya Tummala
Date: Wed May 22 2019 - 23:52:54 EST


On Fri, May 17, 2019 at 10:23:12AM +0200, Christoph Hellwig wrote:
> On Thu, May 16, 2019 at 06:27:53PM +0530, stummala@xxxxxxxxxxxxxx wrote:
> > Hi Christoph, Al,
> >
> > Can you please consider this patch for merging?
>
> I've been sitting on this for a while, mostly because I can't convince
> myself it is safe. What protects other threads from using ->s_dentry
> just when we clear it? Also why would sd->s_dentry == dentry ever be
> false?

Thanks Christoph for getting back on this.
I will try to find answers to your queries and get back on this.

Besides, Al Viro reviewed this patch [1] and commented that fix looks
good. Hence, I was following up to get this merged as I thought it
must be a miss to not pick it up :)

[1] - https://lkml.org/lkml/2019/1/3/47

Thanks,
Sahitya.

--
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.