Re: [PATCH] regulator: max77650: Move max77651_SBB1_desc's declaration down

From: Axel Lin
Date: Wed May 22 2019 - 21:43:16 EST


Nathan Chancellor <natechancellor@xxxxxxxxx> æ 2019å5æ23æ éå äå9:27åéï
>
> Clang warns:
>
> drivers/regulator/max77650-regulator.c:32:39: warning: tentative
> definition of variable with internal linkage has incomplete non-array
> type 'struct max77650_regulator_desc'
> [-Wtentative-definition-incomplete-type]
> static struct max77650_regulator_desc max77651_SBB1_desc;
> ^
> drivers/regulator/max77650-regulator.c:32:15: note: forward declaration
> of 'struct max77650_regulator_desc'
> static struct max77650_regulator_desc max77651_SBB1_desc;
> ^
> 1 warning generated.
>
> Move max77651_SBB1_desc's declaration below max77650_regulator_desc's
> definition so this warning does not happen.
>
> Fixes: 3df4235ac41c ("regulator: max77650: Convert MAX77651 SBB1 to pickable linear range")
> Link: https://github.com/ClangBuiltLinux/linux/issues/491
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
Reviewed-by: Axel Lin <axel.lin@xxxxxxxxxx>