Re: Re: [PATCH v3 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

From: Vinod Koul
Date: Tue May 21 2019 - 01:15:23 EST


On 21-05-19, 04:58, Robin Gong wrote:
> > -----Original Message-----
> > From: Vinod Koul <vkoul@xxxxxxxxxx>
> > Sent: 2019å5æ21æ 12:18
> >
> > On 07-05-19, 09:16, Robin Gong wrote:
> > > Because the number of ecspi1 rx event on i.mx8mm is 0, the condition
> > > check ignore such special case without dma channel enabled, which
> > > caused
> > > ecspi1 rx works failed. Actually, no need to check event_id0, checking
> > > event_id1 is enough for DEV_2_DEV case because it's so lucky that
> > > event_id1 never be 0.
> >
> > Well is that by chance or design that event_id1 will be never 0?
> >
> That's by chance. DEV_2_DEV is just for Audio case and non-zero for event_id1 on current i.MX family.

Then it wont be fgood to rely on chance :)

--
~Vinod