Re: [PATCH net] net: stmmac: fix ethtool flow control not able to get/set

From: Andrew Lunn
Date: Mon May 20 2019 - 17:23:17 EST


On Tue, May 21, 2019 at 12:55:42PM +0800, Weifeng Voon wrote:
> From: "Tan, Tee Min" <tee.min.tan@xxxxxxxxx>
>
> Currently ethtool was not able to get/set the flow control due to a
> missing "!". It will always return -EOPNOTSUPP even the device is
> flow control supported.
>
> This patch fixes the condition check for ethtool flow control get/set
> function for ETHTOOL_LINK_MODE_Asym_Pause_BIT.
>
> Fixes: 3c1bcc8614db (ânet: ethernet: Convert phydev advertize and supported from u32 to link modeâ)
> Signed-off-by: Tan, Tee Min <tee.min.tan@xxxxxxxxx>
> Reviewed-by: Ong Boon Leong <boon.leong.ong@xxxxxxxxx>
> Signed-off-by: Voon, Weifeng <weifeng.voon@xxxxxxxxx@intel.com>

Upps, my bad. Sorry.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew