Re: [STABLE PATCH 1/2] crypto: ccree: zap entire sg on aead request unmap

From: Gilad Ben-Yossef
Date: Mon May 20 2019 - 08:55:25 EST


On Mon, May 20, 2019 at 3:09 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, May 20, 2019 at 02:50:23PM +0300, Gilad Ben-Yossef wrote:
> > We were trying to be clever zapping out of the cache only the required
> > length out of scatter list on AEAD request completion and getting it
> > wrong.
> >
> > As Knuth said: "when in douby, use brute force". Zap the whole length of
> > the scatter list.
> >
> > Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>
> > ---
> > drivers/crypto/ccree/cc_buffer_mgr.c | 18 ++----------------
> > 1 file changed, 2 insertions(+), 16 deletions(-)
>
> This does not apply on top of my latest 4.19 tree with the current
> pending queue applied, nor does it apply to 5.1 or 5.0.
>
> How about waiting a few days and resending after I do the next round of
> stable updates, so you can rebase on top of them easier?

Yes, will do.

Thanks,
Gilad

--
Gilad Ben-Yossef
Chief Coffee Drinker

values of Î will give rise to dom!