Re: [PATCH] tipc: fix modprobe tipc failed after switch order of device registration

From: David Miller
Date: Fri May 17 2019 - 14:43:24 EST


From: hujunwei <hujunwei4@xxxxxxxxxx>
Date: Fri, 17 May 2019 19:27:34 +0800

> From: Junwei Hu <hujunwei4@xxxxxxxxxx>
>
> Error message printed:
> modprobe: ERROR: could not insert 'tipc': Address family not
> supported by protocol.
> when modprobe tipc after the following patch: switch order of
> device registration, commit 7e27e8d6130c
> ("tipc: switch order of device registration to fix a crash")
>
> Because sock_create_kern(net, AF_TIPC, ...) is called by
> tipc_topsrv_create_listener() in the initialization process
> of tipc_net_ops, tipc_socket_init() must be execute before that.
>
> I move tipc_socket_init() into function tipc_init_net().
>
> Fixes: 7e27e8d6130c
> ("tipc: switch order of device registration to fix a crash")
> Signed-off-by: Junwei Hu <hujunwei4@xxxxxxxxxx>
> Reported-by: Wang Wang <wangwang2@xxxxxxxxxx>
> Reviewed-by: Kang Zhou <zhoukang7@xxxxxxxxxx>
> Reviewed-by: Suanming Mou <mousuanming@xxxxxxxxxx>

Applied.