Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (3)

[Todd Kjos]

On Fri, May 17, 2019 at 8:33 AM Dmitry Vyukov <dvyukov@xxxxxxxxxx> wrote:
>
> On Fri, May 17, 2019 at 5:26 PM Todd Kjos <tkjos@xxxxxxxxxx> wrote:
> >
> > Yes (and syzbot seemed to confirm the fix). I didn't realize I needed
> > to manually close the issue. I guess you closed it yesterday.
>
> This is required to auto-close the bug when the commit is merged:
>
> > IMPORTANT: if you fix the bug, please add the following tag to the commit:
> > Reported-by: syzbot+f9f3f388440283da2965@xxxxxxxxxxxxxxxxxxxxxxxxx
>
> Otherwise somebody needs to say:
>
> #syz fix: binder: fix BUG_ON found by selinux-testsuite

It looks like you closed it with your #sys comment ^^^

>
>
> > From: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> > Date: Fri, May 17, 2019 at 3:08 AM
> > To: syzbot
> > Cc: Arve HjÃnnevÃg, Christian Brauner, open list:ANDROID DRIVERS, Greg
> > Kroah-Hartman, Joel Fernandes, LKML, Martijn Coenen, syzkaller-bugs,
> > Todd Kjos <tkjos@xxxxxxxxxxx>, Todd Kjos <tkjos@xxxxxxxxxx>
> >
> > > On Fri, Mar 29, 2019 at 10:55 AM syzbot
> > > <syzbot+f9f3f388440283da2965@xxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > > >
> > > > Hello,
> > > >
> > > > syzbot has tested the proposed patch and the reproducer did not trigger
> > > > crash:
> > > >
> > > > Reported-and-tested-by:
> > > > syzbot+f9f3f388440283da2965@xxxxxxxxxxxxxxxxxxxxxxxxx
> > > >
> > > > Tested on:
> > > >
> > > > commit:         8c2ffd91 Linux 5.1-rc2
> > > > git tree:
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git master
> > > > kernel config:  https://syzkaller.appspot.com/x/.config?x=8dcdce25ea72bedf
> > > > compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
> > > > patch:          https://syzkaller.appspot.com/x/patch.diff?x=10fed663200000
> > > >
> > > > Note: testing is done by a robot and is best-effort only.
> > >
> > >
> > > Todd,
> > >
> > > Should this patch fix the bug? Should we close the bug as fixed then?
> > > In my local testing I see this BUG still fires, but if we will leave
> > > old fixed bugs open, we will not get notifications about new crashes.