Re: [alsa-devel] [PATCH] ASoC: AK4458: add regulator for ak4458

[Viorel Suman]

On Jo, 2019-05-16 at 10:14 -0300, Fabio Estevam wrote:
> On Thu, May 16, 2019 at 10:02 AM Viorel Suman <viorel.suman@xxxxxxx> wrote:
> 
> > 
> > +ÂÂÂÂÂÂÂfor (i = 0; i < ARRAY_SIZE(ak4458->supplies); i++)
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂak4458->supplies[i].supply = ak4458_supply_names[i];
> > +
> > +ÂÂÂÂÂÂÂret = devm_regulator_bulk_get(ak4458->dev, ARRAY_SIZE(ak4458->supplies),
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂak4458->supplies);
> > +ÂÂÂÂÂÂÂif (ret != 0) {
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂdev_err(ak4458->dev, "Failed to request supplies: %d\n", ret);
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturn ret;
> This would break existing users that do not pass the regulators in device tree.
> 
> Ok, in this case there is no ak4458 user in any dts, so that would not
> be an issue.
> 
> Please update the dt-bindings with the regulator entries.

Thanks, will send in V2.

/Viorel