Re: [PATCH] gcc-plugins: arm_ssp_per_task_plugin: Fix for older GCC < 6

[Ard Biesheuvel]

On Sat, 11 May 2019 at 00:42, Doug Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> Hi,
>
> > Use gen_rtx_set instead of gen_rtx_SET. The former is a wrapper macro
> > that handles the difference between GCC versions implementing
> > the latter.
> >
> > This fixes the following error on my system with g++ 5.4.0 as the host
> > compiler
> >
> >    HOSTCXX -fPIC scripts/gcc-plugins/arm_ssp_per_task_plugin.o
> >  scripts/gcc-plugins/arm_ssp_per_task_plugin.c:42:14: error: macro "gen_rtx_SET" requires 3 arguments, but only 2 given
> >           mask)),
> >                ^
> >  scripts/gcc-plugins/arm_ssp_per_task_plugin.c: In function âunsigned int arm_pertask_ssp_rtl_execute()â:
> >  scripts/gcc-plugins/arm_ssp_per_task_plugin.c:39:20: error: âgen_rtx_SETâ was not declared in this scope
> >     emit_insn_before(gen_rtx_SET
> >
> > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> > ---
> >  scripts/gcc-plugins/arm_ssp_per_task_plugin.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> I can confirm that I was getting compile errors before this patch and
> applying it allowed me to compile and boot.  Thanks!  :-)
>
> Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>