Removal of dump_stack()s from /fs/ubifs/io.c

From: Shreya Gangan (shgangan)
Date: Wed May 15 2019 - 16:54:28 EST


Hi,

/fs/ubifs/io.c has dump_stack() in multiple functions upon errors and sometimes warnings.
Since the error and warning messages seem to be unique, the functional value of these dump_stacks is not apparent.
Why are these dump_stacks required and what issues might occur upon the removal of these?

Example:
What is the usecase of the dump_stack in the following code snippet in file /fs/ubifs/io.c?
if (err) {
ubifs_err(c, "changing %d bytes in LEB %d failed, error %d",
len, lnum, err);
ubifs_ro_mode(c, err);
dump_stack();
}

Regards,