Re: [PATCH 00/18] net: introduce Qualcomm IPA driver

From: Arnd Bergmann
Date: Wed May 15 2019 - 08:39:27 EST


On Sun, May 12, 2019 at 3:25 AM Alex Elder <elder@xxxxxxxxxx> wrote:
>
> A version of this code was posted in November 2018 as an RFC.
> https://lore.kernel.org/lkml/20181107003250.5832-1-elder@xxxxxxxxxx/
> Fixes addressing all feedback received have been implemented. It
> has undergone considerable further rework since that time, and
> most of the "future work" described then has now been completed.

I think this has turned out really well now. I've gone through the patches
today and not found any real show-stoppers, but replied with a couple of
minor things I noticed.

I think it's probably worth rearranging the rx and tx code to avoid
the spinlocks, which would be the main optimization I can still
think of to reduce the coherency traffic.

Arnd