Re: [PATCH] mfd: stmfx: Fix macro definition spelling

From: Nathan Chancellor
Date: Tue May 14 2019 - 14:40:49 EST


On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote:
> On Fri, 10 May 2019, Nathan Chancellor wrote:
>
> > Clang warns:
> >
> > In file included from drivers/mfd/stmfx.c:13:
> > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a
> > header guard here, followed by #define of a different macro
> > [-Wheader-guard]
> >
> > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/475
> > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> > ---
> > include/linux/mfd/stmfx.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied, thanks.
>
> --
> Lee Jones [æçæ]
> Linaro Services Technical Lead
> Linaro.org â Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

Hi Lee,

Thanks for picking it up. It seems this didn't make it into your MFD
pull request for 5.2, was that intentional? It would be nice to avoid
this warning.

Thanks,
Nathan