Re: [PATCH 2/3] KVM: LAPIC: Fix lapic_timer_advance_ns parameter overflow

From: Sean Christopherson
Date: Mon May 13 2019 - 15:16:20 EST


On Thu, May 09, 2019 at 07:29:20PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <wanpengli@xxxxxxxxxxx>
>
> After commit c3941d9e0 (KVM: lapic: Allow user to disable adaptive tuning of
> timer advancement), '-1' enables adaptive tuning starting from default
> advancment of 1000ns. However, we should expose an int instead of an overflow
> uint module parameter.
>
> Before patch:
>
> /sys/module/kvm/parameters/lapic_timer_advance_ns:4294967295
>
> After patch:
>
> /sys/module/kvm/parameters/lapic_timer_advance_ns:-1
>
> Fixes: c3941d9e0 (KVM: lapic: Allow user to disable adaptive tuning of timer advancement)
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Cc: Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx>
> Cc: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> Cc: Liran Alon <liran.alon@xxxxxxxxxx>
> Signed-off-by: Wanpeng Li <wanpengli@xxxxxxxxxxx>
> ---

Reviewed-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>