Re: [PATCH] mfd: stmfx: Fix macro definition spelling

From: Amelie DELAUNAY
Date: Mon May 13 2019 - 03:12:46 EST


On 5/11/19 3:23 AM, Nathan Chancellor wrote:
> Clang warns:
>
> In file included from drivers/mfd/stmfx.c:13:
> include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a
> header guard here, followed by #define of a different macro
> [-Wheader-guard]
>
> Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver")
> Link: https://github.com/ClangBuiltLinux/linux/issues/475
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>

Reviewed-by: Amelie Delaunay <amelie.delaunay@xxxxxx>

> ---
> include/linux/mfd/stmfx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mfd/stmfx.h b/include/linux/mfd/stmfx.h
> index d890595b89b6..3c67983678ec 100644
> --- a/include/linux/mfd/stmfx.h
> +++ b/include/linux/mfd/stmfx.h
> @@ -5,7 +5,7 @@
> */
>
> #ifndef MFD_STMFX_H
> -#define MFX_STMFX_H
> +#define MFD_STMFX_H
>
> #include <linux/regmap.h>
>
>