Re: [PATCH v4 00/10] PCI: Log with pci_dev, not pcie_device

From: Andy Shevchenko
Date: Thu May 09 2019 - 13:50:34 EST


On Thu, May 9, 2019 at 5:18 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>
> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
> This is a collection of updates to Fred's v2 patches from:
>
> https://lore.kernel.org/lkml/20190503035946.23608-1-fred@xxxxxxxxxxxx
>
> and some follow-on discussion.
>

For non-commented patches,
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

For the commented ones, I hope you will address them, and then my tag
applies for them as well.

> Bjorn Helgaas (3):
> PCI: pciehp: Remove pciehp_debug uses
> PCI: pciehp: Remove pointless PCIE_MODULE_NAME definition
> PCI: pciehp: Remove pointless MY_NAME definition
>
> Frederick Lawler (7):
> PCI/AER: Replace dev_printk(KERN_DEBUG) with dev_info()
> PCI/PME: Replace dev_printk(KERN_DEBUG) with dev_info()
> PCI/DPC: Log messages with pci_dev, not pcie_device
> PCI/AER: Log messages with pci_dev, not pcie_device
> PCI: pciehp: Replace pciehp_debug module param with dyndbg
> PCI: pciehp: Log messages with pci_dev, not pcie_device
> PCI: pciehp: Remove unused dbg/err/info/warn() wrappers
>
> drivers/pci/hotplug/pciehp.h | 31 +++++++-------------------
> drivers/pci/hotplug/pciehp_core.c | 18 +++++++--------
> drivers/pci/hotplug/pciehp_ctrl.c | 2 ++
> drivers/pci/hotplug/pciehp_hpc.c | 17 +++++++-------
> drivers/pci/hotplug/pciehp_pci.c | 2 ++
> drivers/pci/pcie/aer.c | 32 ++++++++++++++------------
> drivers/pci/pcie/aer_inject.c | 22 +++++++++---------
> drivers/pci/pcie/dpc.c | 37 +++++++++++++++----------------
> drivers/pci/pcie/pme.c | 10 +++++----
> 9 files changed, 82 insertions(+), 89 deletions(-)
>
> --
> 2.21.0.1020.gf2820cf01a-goog
>


--
With Best Regards,
Andy Shevchenko