Re: [PATCH v3 0/7] crypto: x86: Fix indirect function call casts

From: Herbert Xu
Date: Wed May 08 2019 - 21:40:29 EST


On Wed, May 08, 2019 at 02:08:25PM -0700, Kees Cook wrote:
>
> For example, quoting the existing code:
>
> asmlinkage void twofish_dec_blk(struct twofish_ctx *ctx, u8 *dst,
> const u8 *src);

So just make it

asmlinkage void twofish_dec_blk(void *ctx, u8 *dst, const u8 *src);

and you won't need any of these casts.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt