Re: [alsa-devel] [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

From: Pierre-Louis Bossart
Date: Tue May 07 2019 - 17:07:44 EST



What we are missing are the PCI IDs for CML PCH-LP (0x02C8) and CML
PCH-H (0x06C8).

Can we respin this patchset to add support for those last two instead of
just the -LP case?

Sure. So just to clarify, you want the entry for 0x02c8, and you want
an additional entry for 0x06c8 under the same config. Will do.

I'd like both entries but with different Kconfigs (e.g. CometLake-LP and CometLake-H). We have one PCI ID per Kconfig so far.


I'll send a patch to add those IDs for the HDaudio legacy driver for
consistency.

Actually I've got that change ready to go too, I'm happy to send that out.

I guess I beat you to it.
Thanks for reporting all this.
-Pierre