Re: [alsa-devel] [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

[Pierre-Louis Bossart]

> On 5/6/19 5:53 PM, Evan Green wrote:
> > > Add support for Intel Comet Lake platforms by adding a new Kconfig for
> > > CometLake and the appropriate PCI ID.
>
> > This is odd. I checked internally a few weeks back and the CML PCI ID was 9dc8, same as WHL and CNL, so we did not add a PCI ID on purpose. To the best of my knowledge SOF probes fine on CML and the known issues can be found on the SOF github [1].
>
> The PCI ID change is seen on later production Si versions. The PCI ID is 02c8.

As I suspected, we are talking about different skews and generations of 
the chipset and a board-level change, not silicon change.

The CNL PCH-LP PCI ID is 0x9DC8, the CNL PCH-H PCI ID is 0xA348 (used 
for CoffeeLake). Both are supported by SOF.

What we are missing are the PCI IDs for CML PCH-LP (0x02C8) and CML 
PCH-H (0x06C8).

Can we respin this patchset to add support for those last two instead of 
just the -LP case?

I'll send a patch to add those IDs for the HDaudio legacy driver for 
consistency.

Thanks!
-Pierre