Re: [PATCH AUTOSEL 4.14 50/95] fsnotify: generalize handling of extra event flags

[Sasha Levin]

On Tue, May 07, 2019 at 03:23:30PM +0200, Jan Kara wrote:
> On Tue 07-05-19 01:37:39, Sasha Levin wrote:
> > From: Amir Goldstein <amir73il@xxxxxxxxx>
> >
> > [ Upstream commit 007d1e8395eaa59b0e7ad9eb2b53a40859446a88 ]
> >
> > FS_EVENT_ON_CHILD gets a special treatment in fsnotify() because it is
> > not a flag specifying an event type, but rather an extra flags that may
> > be reported along with another event and control the handling of the
> > event by the backend.
> >
> > FS_ISDIR is also an "extra flag" and not an "event type" and therefore
> > desrves the same treatment. With inotify/dnotify backends it was never
> > possible to set FS_ISDIR in mark masks, so it did not matter.
> > With fanotify backend, mark adding code jumps through hoops to avoid
> > setting the FS_ISDIR in the commulative object mask.
> >
> > Separate the constant ALL_FSNOTIFY_EVENTS to ALL_FSNOTIFY_FLAGS and
> > ALL_FSNOTIFY_EVENTS, so the latter can be used to test for specific
> > event types.
> >
> > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx>
> > Signed-off-by: Jan Kara <jack@xxxxxxx>
> > Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx>
>
> Sasha, why did you select this patch? It is just a cleanup with no user
> visible effect and was done mostly to simplify implementing following
> features...

Sigh, my script picked up the patch after this one (by mistake). I've
dropped that one but missed this one twice(!). Thanks for the heads-up,
I'll drop it.

--
Thanks,
Sasha