RE: [PATCH] cifs: fix strcat buffer overflow in smb21_set_oplock_level()

[David Laight]

From: Christoph Probst
> Sent: 07 May 2019 07:10
> Steve French schrieb am 06.05.2019 um 23:18 Uhr:
> 
> > On Mon, May 6, 2019 at 2:03 PM Pavel Shilovsky
> > <pavel.shilovsky@xxxxxxxxx> wrote:
> > >
> > > The patch itself is fine but I think we have a bigger problem here:
> >
> > Good point.  Perhaps make update to the same patch to include both changes
> 
> I'll update my patch to implement the change suggested by Pavel.
> 
> I'll also switch the strcat to strncat and use strncpy in the "None"-case.

strncat() is never the function you are looking for.
The 'n' is the maximum number of bytes to copy, not the length
of the target buffer.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)