Re: [PATCH -next] ocxl: Fix return value check in afu_ioctl()

From: Michael Ellerman
Date: Mon May 06 2019 - 09:54:48 EST


On Sat, 2019-05-04 at 07:04:30 UTC, Wei Yongjun wrote:
> In case of error, the function eventfd_ctx_fdget() returns ERR_PTR() and
> never returns NULL. The NULL test in the return value check should be
> replaced with IS_ERR().
>
> This issue was detected by using the Coccinelle software.
>
> Fixes: 060146614643 ("ocxl: move event_fd handling to frontend")
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> Acked-by: Alastair D'Silva <alastair@xxxxxxxxxxx>
> Acked-by: Andrew Donnellan <ajd@xxxxxxxxxxxxx>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/6be6a8de1b55e719e3f9589491074371

cheers