Re: [PATCH next 20/25] platform/x86: asus-wmi: Use dev_get_drvdata()

From: Andy Shevchenko
Date: Mon May 06 2019 - 05:02:32 EST


On Tue, Apr 23, 2019 at 10:40 AM Kefeng Wang <wangkefeng.wang@xxxxxxxxxx> wrote:
>
> Using dev_get_drvdata directly.
>

Acked-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

> Cc: Darren Hart <dvhart@xxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx>
> Cc: platform-driver-x86@xxxxxxxxxxxxxxx
> Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
> ---
> drivers/platform/x86/asus-wmi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index ee1fa93708ec..fb9e4e02c068 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -1361,8 +1361,7 @@ static umode_t asus_hwmon_sysfs_is_visible(struct kobject *kobj,
> struct attribute *attr, int idx)
> {
> struct device *dev = container_of(kobj, struct device, kobj);
> - struct platform_device *pdev = to_platform_device(dev->parent);
> - struct asus_wmi *asus = platform_get_drvdata(pdev);
> + struct asus_wmi *asus = dev_get_drvdata(dev->parent);
> int dev_id = -1;
> int fan_attr = -1;
> u32 value = ASUS_WMI_UNSUPPORTED_METHOD;
> --
> 2.20.1
>


--
With Best Regards,
Andy Shevchenko