Re: [PATCH v3 2/4] add the buffer to the xattr

From: Mimi Zohar
Date: Thu May 02 2019 - 12:52:57 EST


On Mon, 2019-04-29 at 14:47 -0700, Prakhar Srivastava wrote:
> From: Prakhar Srivastava <prsriva02@xxxxxxxxx>
>
> add the buffer to the xattr for a buffer case

Please write full patch descriptions, here and in the other patches,
explaining the current status with the motivation for the change.

>
> Signed-off-by: Prakhar Srivastava <prsriva02@xxxxxxxxx>
> ---

< snip >
>
> @@ -630,17 +651,23 @@ static int process_buffer_measurement(const void *buff, int size,
> if (ret < 0)
> goto err_out;
>
> - ret = ima_store_template(entry, violation, NULL,
> + if (action & IMA_MEASURE)
> + ret = ima_store_template(entry, violation, NULL,
> buff, pcr);

Although scripts/Lindent has its problems, it does a good job with
code formatting. ÂThere's no reason here for the line breakage.

Mimi