Re: [PATCH 0/3] block: sed-opal: add support for shadow MBR done flag and write

From: David Kozub
Date: Thu May 02 2019 - 12:03:52 EST


On Thu, 2 May 2019, Scott Bauer wrote:

On Wed, May 01, 2019 at 01:20:56AM +0200, David Kozub wrote:

Jonas Rabenstein (3):
block: sed-opal: add ioctl for done-mark of shadow mbr
block: sed-opal: ioctl for writing to shadow mbr
block: sed-opal: check size of shadow mbr

block/opal_proto.h | 16 ++++
block/sed-opal.c | 160 +++++++++++++++++++++++++++++++++-
include/linux/sed-opal.h | 2 +
include/uapi/linux/sed-opal.h | 20 +++++
4 files changed, 196 insertions(+), 2 deletions(-)


I'll review this over the weekend. Is this essentially the same thing
we reviewed a month or two ago or are there little differences due to
it be split across two different series?

The first patch (block: sed-opal: add ioctl for done-mark of shadow mbr) is a bit different because a new struct and enum were introduced. The rest is pretty much the same. That's also why I kept the reviewd-by tags.

Best regards,
David