Re: [linux-sunxi] Re: [PATCH v5 3/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller

From: Pablo SebastiÃn Greco
Date: Thu May 02 2019 - 06:25:53 EST



El 2/5/19 a las 04:39, Maxime Ripard escribiÃ:
On Tue, Apr 23, 2019 at 02:26:00PM -0300, Pablo Greco wrote:
Just like the Bananapi M2 Ultra, the Bananapi M2 Berry has a Realtek
RTL8211E RGMII PHY tied to the GMAC.
The PMIC's DC1SW output provides power for the PHY, while the ALDO2
output provides I/O voltages on both sides.

Signed-off-by: Pablo Greco <pgreco@xxxxxxxxxxxxxxxxx>
---
arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 29 +++++++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
index 2cb2ce0..561319b 100644
--- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
+++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
@@ -50,6 +50,7 @@
compatible = "sinovoip,bpi-m2-berry", "allwinner,sun8i-r40";

aliases {
+ ethernet0 = &gmac;
serial0 = &uart0;
};

@@ -92,6 +93,22 @@
status = "okay";
};

+&gmac {
+ pinctrl-names = "default";
+ pinctrl-0 = <&gmac_rgmii_pins>;
+ phy-handle = <&phy1>;
+ phy-mode = "rgmii";
+ phy-supply = <&reg_dc1sw>;
+ status = "okay";
+};
+
+&gmac_mdio {
+ phy1: ethernet-phy@1 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <1>;
+ };
+};
+
&i2c0 {
status = "okay";

@@ -133,6 +150,12 @@
vcc-pg-supply = <&reg_dldo1>;
};

+&reg_aldo2 {
+ regulator-min-microvolt = <2500000>;
+ regulator-max-microvolt = <2500000>;
+ regulator-name = "vcc-pa";
+};
+
Shouldn't this one be added to the patch 2?

Thanks
Maxime
Yes, I'll do that in next version
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Pablo.