RE: [EXT] Re: [PATCH 1/4] mtd: rawnand: Turn the ONFI support to generic

From: Shivamurthy Shastri (sshivamurthy)
Date: Thu May 02 2019 - 04:34:27 EST


Hi Miquel,

> Hi Shivamurthy,
>
> Sorry for the long delay I was a bit overloaded.
>
> "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@xxxxxxxxxx> wrote
> on
> Tue, 26 Mar 2019 10:51:47 +0000:
>
> > Fix headers to make way for adding helper functions.
> >
> > Add onfi helper structure.
> >
> > Add helper functions in raw NAND core, which later will be used during
> > ONFI detection.
> >
>
> As you are touching the core, I need to identify clearly each change
> you make; typically in this commit you do several different changes.
> Please split this patch in small meaningful peaces.
>

I will send the new version.

> > Signed-off-by: Shivamurthy Shastri <sshivamurthy@xxxxxxxxxx>
> > ---
> > drivers/mtd/nand/raw/internals.h | 6 +-
> > drivers/mtd/nand/raw/nand_base.c | 236
> ++++++++++++++++++++++++++++---
> > drivers/mtd/nand/raw/nand_onfi.c | 215 +++++-----------------------
> > include/linux/mtd/nand.h | 30 ++++
> > include/linux/mtd/rawnand.h | 5 +
> > 5 files changed, 289 insertions(+), 203 deletions(-)
> >
>
> Thanks,
> MiquÃl

Thanks,
Shiva