Re: [PATCH v1 2/4] powerpc/mm: Move book3s64 specifics in subdirectory mm/book3s64

[Christophe Leroy]

Le 02/05/2019 Ã 09:11, Michael Ellerman a ÃcritÂ:
> Christophe Leroy <christophe.leroy@xxxxxx> writes:
>
> > Many files in arch/powerpc/mm are only for book3S64. This patch
> > creates a subdirectory for them.
> >
> > Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> > ---
> >   arch/powerpc/mm/Makefile                           | 25 +++----------------
> >   arch/powerpc/mm/book3s64/Makefile                  | 28 ++++++++++++++++++++++
> >   arch/powerpc/mm/{ => book3s64}/hash64_4k.c         |  0
> >   arch/powerpc/mm/{ => book3s64}/hash64_64k.c        |  0
> >   arch/powerpc/mm/{ => book3s64}/hash_native_64.c    |  0
> >   arch/powerpc/mm/{ => book3s64}/hash_utils_64.c     |  0
> >   arch/powerpc/mm/{ => book3s64}/hugepage-hash64.c   |  0
> >   .../powerpc/mm/{ => book3s64}/hugetlbpage-hash64.c |  0
> >   arch/powerpc/mm/{ => book3s64}/hugetlbpage-radix.c |  0
> >   .../mm/{ => book3s64}/mmu_context_book3s64.c       |  0
> >   arch/powerpc/mm/{ => book3s64}/mmu_context_iommu.c |  0
> >   arch/powerpc/mm/{ => book3s64}/pgtable-book3s64.c  |  0
> >   arch/powerpc/mm/{ => book3s64}/pgtable-hash64.c    |  0
> >   arch/powerpc/mm/{ => book3s64}/pgtable-radix.c     |  0
> >   arch/powerpc/mm/{ => book3s64}/pkeys.c             |  0
> >   arch/powerpc/mm/{ => book3s64}/slb.c               |  0
> >   arch/powerpc/mm/{ => book3s64}/subpage-prot.c      |  0
> >   arch/powerpc/mm/{ => book3s64}/tlb-radix.c         |  0
> >   arch/powerpc/mm/{ => book3s64}/tlb_hash64.c        |  0
> >   arch/powerpc/mm/{ => book3s64}/vphn.c              |  0
> >   arch/powerpc/mm/{ => book3s64}/vphn.h              |  0
> >   arch/powerpc/mm/numa.c                             |  2 +-
> >   22 files changed, 32 insertions(+), 23 deletions(-)
> >   create mode 100644 arch/powerpc/mm/book3s64/Makefile
> >   rename arch/powerpc/mm/{ => book3s64}/hash64_4k.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/hash64_64k.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/hash_native_64.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/hash_utils_64.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/hugepage-hash64.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/hugetlbpage-hash64.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/hugetlbpage-radix.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/mmu_context_book3s64.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/mmu_context_iommu.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/pgtable-book3s64.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/pgtable-hash64.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/pgtable-radix.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/pkeys.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/slb.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/subpage-prot.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/tlb-radix.c (100%)
> >   rename arch/powerpc/mm/{ => book3s64}/tlb_hash64.c (100%)
>
> Do you mind if I take this but rework the destination names in the process?

I don't mind, I think it's a good idea.

> I don't like having eg. book3s64/pgtable-book3s64.c
>
> And some of the other names could use a bit of cleanup too.
>
> What about:
>
>   arch/powerpc/mm/{hash64_4k.c => book3s64/hash_4k.c}
>   arch/powerpc/mm/{hash64_64k.c => book3s64/hash_64k.c}
>   arch/powerpc/mm/{hugepage-hash64.c => book3s64/hash_hugepage.c}
>   arch/powerpc/mm/{hugetlbpage-hash64.c => book3s64/hash_hugetlbpage.c}
>   arch/powerpc/mm/{hash_native_64.c => book3s64/hash_native.c}
>   arch/powerpc/mm/{pgtable-hash64.c => book3s64/hash_pgtable.c}
>   arch/powerpc/mm/{tlb_hash64.c => book3s64/hash_tlb.c}
>   arch/powerpc/mm/{hash_utils_64.c => book3s64/hash_utils.c}
>   arch/powerpc/mm/{mmu_context_iommu.c => book3s64/iommu_api.c}
>   arch/powerpc/mm/{mmu_context_book3s64.c => book3s64/mmu_context.c}
>   arch/powerpc/mm/{pgtable-book3s64.c => book3s64/pgtable.c}
>   arch/powerpc/mm/{hugetlbpage-radix.c => book3s64/radix_hugetlbpage.c}
>   arch/powerpc/mm/{pgtable-radix.c => book3s64/radix_pgtable.c}
>   arch/powerpc/mm/{tlb-radix.c => book3s64/radix_tlb.c}

Looks good

Christophe