Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier

From: Greg Kroah-Hartman
Date: Thu May 02 2019 - 03:08:08 EST


On Wed, May 01, 2019 at 10:20:44PM +0200, Andreas Färber wrote:
> + linux-actions
>
> Am 01.05.19 um 09:07 schrieb Nishad Kamdar:
> > This patch corrects the SPDX License Identifier style
> > in header files related to Clock Drivers for Actions Semi Socs.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used)
> [...]
> > drivers/clk/actions/owl-common.h | 2 +-
> > drivers/clk/actions/owl-composite.h | 2 +-
> > drivers/clk/actions/owl-divider.h | 2 +-
> > drivers/clk/actions/owl-factor.h | 2 +-
> > drivers/clk/actions/owl-fixed-factor.h | 2 +-
> > drivers/clk/actions/owl-gate.h | 2 +-
> > drivers/clk/actions/owl-mux.h | 2 +-
> > drivers/clk/actions/owl-pll.h | 2 +-
> > drivers/clk/actions/owl-reset.h | 2 +-
> > 9 files changed, 9 insertions(+), 9 deletions(-)
>
> Where's the practical benefit of this patch? These are all private
> headers used from C files, so they can handle C++ comments just fine,
> otherwise we would've seen build failures.

Please read Documentation/process/license-rules.rst, the section
entitled "Style", for what the documented formats are for SPDX lines,
depending on the file type.

thanks,

greg k-h